linux-kernel - Re: [PATCH] arm64: tegra: correct Tegra132 I2C alias

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <88eeb7a5-540d-487b-a267-37d724f142d2@nvidia.com>
Date: Tue, 2 Apr 2024 20:20:28 +0100
From: Jon Hunter <jonathanh@...dia.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, Thierry Reding
 <thierry.reding@...il.com>, devicetree@...r.kernel.org,
 linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: stable@...r.kernel.org
Subject: Re: [PATCH] arm64: tegra: correct Tegra132 I2C alias


On 01/04/2024 15:08, Krzysztof Kozlowski wrote:
> There is no such device as "as3722@40", because its name is "pmic".  Use
> phandles for aliases to fix relying on full node path.  This corrects
> aliases for RTC devices and also fixes dtc W=1 warning:
> 
>    tegra132-norrin.dts:12.3-36: Warning (alias_paths): /aliases:rtc0: aliases property is not a valid node (/i2c@...0d000/as3722@40)
> 
> Fixes: 0f279ebdf3ce ("arm64: tegra: Add NVIDIA Tegra132 Norrin support")
> Cc: <stable@...r.kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> ---
>   arch/arm64/boot/dts/nvidia/tegra132-norrin.dts | 4 ++--
>   arch/arm64/boot/dts/nvidia/tegra132.dtsi       | 2 +-
>   2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts b/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts
> index 14d58859bb55..683ac124523b 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts
> +++ b/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts
> @@ -9,8 +9,8 @@ / {
>   	compatible = "nvidia,norrin", "nvidia,tegra132", "nvidia,tegra124";
>   
>   	aliases {
> -		rtc0 = "/i2c@...0d000/as3722@40";
> -		rtc1 = "/rtc@...0e000";
> +		rtc0 = &as3722;
> +		rtc1 = &tegra_rtc;
>   		serial0 = &uarta;
>   	};
>   
> diff --git a/arch/arm64/boot/dts/nvidia/tegra132.dtsi b/arch/arm64/boot/dts/nvidia/tegra132.dtsi
> index 7e24a212c7e4..5bcccfef3f7f 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra132.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra132.dtsi
> @@ -572,7 +572,7 @@ spi@...0de00 {
>   		status = "disabled";
>   	};
>   
> -	rtc@...0e000 {
> +	tegra_rtc: rtc@...0e000 {
>   		compatible = "nvidia,tegra124-rtc", "nvidia,tegra20-rtc";
>   		reg = <0x0 0x7000e000 0x0 0x100>;
>   		interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>;


Reviewed-by: Jon Hunter <jonathanh@...dia.com>

Thanks!
Jon

-- 
nvpublic