linux-kernel - Re: [PATCH 1/2] perf annotate: Get rid of duplicate --group option item

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZgxtKVSwAbFXK01k@x1>
Date: Tue, 2 Apr 2024 17:40:09 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: "Liang, Kan" <kan.liang@...ux.intel.com>
Cc: Namhyung Kim <namhyung@...nel.org>, Ian Rogers <irogers@...gle.com>,
	Jiri Olsa <jolsa@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...nel.org>, LKML <linux-kernel@...r.kernel.org>,
	linux-perf-users@...r.kernel.org
Subject: Re: [PATCH 1/2] perf annotate: Get rid of duplicate --group option
 item

On Mon, Mar 25, 2024 at 09:56:50AM -0400, Liang, Kan wrote:
> 
> 
> On 2024-03-22 6:43 p.m., Namhyung Kim wrote:
> > The options array in cmd_annotate() has duplicate --group options.  It
> > only needs one and let's get rid of the other.
> > 
> >   $ perf annotate -h 2>&1 | grep group
> >         --group           Show event group information together
> >         --group           Show event group information together
> > 
> > Fixes: 7ebaf4890f63 ("perf annotate: Support '--group' option")
> > Signed-off-by: Namhyung Kim <namhyung@...nel.org>
> 
> For the series,
> 
> Reviewed-by: Kan Liang <kan.liang@...ux.intel.com>

For 'b4' sake, next time please send the Reviewed-by to the cover letter
in the series so that it picks your Reviewed-by for all patches, not
just for the one that you replied to, as in this case.

I'm adding it to this whole series,

Thanks!

- Arnaldo