linux-kernel - Re: [PATCH v5 1/2] Documentation: coding-style: ask function-like macros to evaluate parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <69ee112aadc8ef8ed7d819308f02dc58e56bb0a6.camel@perches.com>
Date: Tue, 02 Apr 2024 14:54:34 -0700
From: Joe Perches <joe@...ches.com>
To: Barry Song <21cnbao@...il.com>, Jonathan Corbet <corbet@....net>
Cc: akpm@...ux-foundation.org, linux-doc@...r.kernel.org, 
 workflows@...r.kernel.org, apw@...onical.com, broonie@...nel.org, 
 chenhuacai@...ngson.cn, chris@...kel.net, dwaipayanray1@...il.com, 
 herbert@...dor.apana.org.au, linux-kernel@...r.kernel.org,
 linux@...ck-us.net,  lukas.bulwahn@...il.com, mac.xxn@...look.com,
 sfr@...b.auug.org.au,  v-songbaohua@...o.com, Max Filippov
 <jcmvbkbc@...il.com>
Subject: Re: [PATCH v5 1/2] Documentation: coding-style: ask function-like
 macros to evaluate parameters

On Wed, 2024-04-03 at 10:21 +1300, Barry Song wrote:
> On Wed, Apr 3, 2024 at 5:13 AM Jonathan Corbet <corbet@....net> wrote:
> > 
> > So I'm not sure what your desired path for getting this upstream is.  I
> > can take it, but I'm generally quite leery of taking coding-style
> > changes without some serious acks on them - nobody elected me as the
> > arbiter of proper coding style.

I believe it is generally appropriate for macros that take
arguments to use static inlines where feasible, so:

Acked-by: Joe Perches <joe@...ches.com>

And yes, mm is the usual path for upstreaming at least this
sort of checkpatch change.