[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAM9d7cgyeaeTPyw5fZjX2OsVrGqv-VrqpU_RPgUu8yWN+qTDsg@mail.gmail.com>
Date: Tue, 2 Apr 2024 16:03:33 -0700
From: Namhyung Kim <namhyung@...nel.org>
To: Arnaldo Carvalho de Melo <acme@...nel.org>
Cc: Ian Rogers <irogers@...gle.com>, Kan Liang <kan.liang@...ux.intel.com>,
Jiri Olsa <jolsa@...nel.org>, Adrian Hunter <adrian.hunter@...el.com>,
Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...nel.org>,
LKML <linux-kernel@...r.kernel.org>, linux-perf-users@...r.kernel.org
Subject: Re: [PATCH v2 3/5] perf annotate: Split out util/disasm.c
On Tue, Apr 2, 2024 at 3:11 PM Arnaldo Carvalho de Melo <acme@...nel.org> wrote:
>
> On Tue, Apr 02, 2024 at 07:08:04PM -0300, Arnaldo Carvalho de Melo wrote:
> > On Fri, Mar 29, 2024 at 02:58:10PM -0700, Namhyung Kim wrote:
> > > The util/annotate.c code has both disassembly and sample annotation
> > > related codes. Factor out the disasm part so that it can be handled
> > > more easily.
> > >
> > > No functional changes intended.
> > >
> >
> > Unsure if here, will check and fix later, detected with:
> >
> > make -C tools/perf build-test'
>
> did it, added the missing env.h header to disasm.c
Thanks a lot!
Namhyung
Powered by blists - more mailing lists