linux-kernel - Re: 6.8 SPI Chip Select Regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <467644bf-85d0-429a-bd11-7155b1cb5fbc@sirena.org.uk>
Date: Wed, 3 Apr 2024 00:52:44 +0100
From: Mark Brown <broonie@...nel.org>
To: Colin Foster <colin.foster@...advantage.com>
Cc: Amit Kumar Mahapatra <amit.kumar-mahapatra@....com>,
	linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: 6.8 SPI Chip Select Regression

On Tue, Apr 02, 2024 at 04:32:50PM -0500, Colin Foster wrote:
> Hi Amit,

Amit, please respond to these issues - you never replied to the mails
about the other regressions this introduced either...

> [    3.459990] omap2_mcspi 48030000.spi: chipselect 0 already in use
> [    3.466135] spi_master spi0: spi_device register error /ocp/interconnect@...00000/segment@...arget-module@...00/spi@...oc@0
> [    3.477495] spi_master spi0: Failed to create SPI device for /ocp/interconnect@...00000/segment@...arget-module@...00/spi@...oc@0

> Is this a known issue? Is there anything I either might need to do to a
> device tree, or something you might suggest to help troubleshoot this?

This is not known, and given that you say there's only one chip select
in use on the system seems clearly bogus.  There were some regressions
with trying to use more than the hard coded maximum number of chip
selects but they have a different error pattern.  It's late so I'll not
look properly right now but...

Do you know what chip select 0 is - if you add a WARN_ON() to
spi_set_chipselect() it should show a prior call to the function, or is
it some logic bug that somehow is not manifesting on other systems that
use chip select 0?  Though looking quickly there has been some factoring
out since that commit was merged...  just to confirm, did you bisect to
find the problematic commit?  If you could show the DT for your setup
that'd help, especially if this is a GPIO chip select.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)