linux-kernel - Re: [PATCH 3/3] nvmem: layouts: sl28vpd: drop driver owner initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240402091723.1923c13c@xps-13>
Date: Tue, 2 Apr 2024 09:17:23 +0200
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>, Michael Walle
 <mwalle@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] nvmem: layouts: sl28vpd: drop driver owner
 initialization

Hi Krzysztof,

krzysztof.kozlowski@...aro.org wrote on Fri, 29 Mar 2024 17:13:37 +0100:

> Core in nvmem_layout_driver_register() already sets the .owner, so
> driver does not need to.
> 

Reviewed-by: Miquel Raynal <miquel.raynal@...tlin.com>

> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
>  drivers/nvmem/layouts/sl28vpd.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/nvmem/layouts/sl28vpd.c b/drivers/nvmem/layouts/sl28vpd.c
> index 53fa50f17dca..e93b020b0836 100644
> --- a/drivers/nvmem/layouts/sl28vpd.c
> +++ b/drivers/nvmem/layouts/sl28vpd.c
> @@ -156,7 +156,6 @@ MODULE_DEVICE_TABLE(of, sl28vpd_of_match_table);
>  
>  static struct nvmem_layout_driver sl28vpd_layout = {
>  	.driver = {
> -		.owner = THIS_MODULE,
>  		.name = "kontron-sl28vpd-layout",
>  		.of_match_table = sl28vpd_of_match_$

Thanks,
Miquèl