linux-kernel - Re: [PATCH] drm/ast: Fix soft lockup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f1e4e73d-7fe4-435a-b301-c11eaf4e10e6@suse.de>
Date: Tue, 2 Apr 2024 11:54:49 +0200
From: Thomas Zimmermann <tzimmermann@...e.de>
To: 黃立銘 <orbit.huang@...il.com>
Cc: Jocelyn Falempe <jfalempe@...hat.com>, maarten.lankhorst@...ux.intel.com,
 mripard@...nel.org, airlied@...hat.com, airlied@...il.com, daniel@...ll.ch,
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
 Jammy Huang <jammy_huang@...eedtech.com>, stable@...r.kernel.org
Subject: Re: [PATCH] drm/ast: Fix soft lockup

Hi

Am 01.04.24 um 04:20 schrieb 黃立銘:
> Hi Thomas and Jocelyn,
>
> What we do in ast_dp_set_on_off() is a handshake between host driver
> and bmc-fw to confirm
> the operation, on/off, is completed.
>
> We use some scratch registers in bmc to handshake with host. This
> handshake only work if
> BMC's scu-lock is opened. If scu-lock is opened too late, then it
> could lead to this issue.

Thanks a lot. Can you please send a new version of this patch with this 
information in the commit message? Please also mention why 200 ms is a 
good upper limit.

The code currently waits and then possibly breaks the loop. Should the 
if-branch be located before the mdelay() statement to avoid any 
unnecessary waiting?

Please also send the patch from your Aspeed email address. Our scripts 
do not accept patches where the sender differs from the Signed-off-by tag.

Best regards
Thomas

>
> Best regards
> Jammy
>
> Thomas Zimmermann <tzimmermann@...e.de> 於 2024年3月28日 週四 上午4:28寫道：
>> Hi
>>
>> Am 27.03.24 um 09:53 schrieb Jocelyn Falempe:
>>> Hi,
>>>
>>> Thanks for your patch.
>>> I'm wondering how you can trigger this infinite loop ?
>> Yeah, a bit more context for this bug would be welcome. It's hard to
>> judge the fix without.
>>
>> Best regards
>> Thomas
>>
>>> Also this looks like a simple fix, that can be easily backported, so
>>> I'm adding stable in Cc.
>>>
>>> If Thomas has no objections, I can push it to drm-misc-fixes.
>>>
>>> Reviewed-by: Jocelyn Falempe <jfalempe@...hat.com>
>>>
>>
>>
>> --
>> --
>> Thomas Zimmermann
>> Graphics Driver Developer
>> SUSE Software Solutions Germany GmbH
>> Frankenstrasse 146, 90461 Nuernberg, Germany
>> GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
>> HRB 36809 (AG Nuernberg)
>>

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)