lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID:
 <DU2PR04MB88225A1F8A245C68071138228C3E2@DU2PR04MB8822.eurprd04.prod.outlook.com>
Date: Tue, 2 Apr 2024 10:20:28 +0000
From: Xu Yang <xu.yang_2@....com>
To: Shawn Guo <shawnguo2@...h.net>
CC: "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"robh+dt@...nel.org" <robh+dt@...nel.org>,
	"krzysztof.kozlowski+dt@...aro.org" <krzysztof.kozlowski+dt@...aro.org>,
	"shawnguo@...nel.org" <shawnguo@...nel.org>, "conor+dt@...nel.org"
	<conor+dt@...nel.org>, "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
	"kernel@...gutronix.de" <kernel@...gutronix.de>, "festevam@...il.com"
	<festevam@...il.com>, dl-linux-imx <linux-imx@....com>,
	"peter.chen@...nel.org" <peter.chen@...nel.org>, Jun Li <jun.li@....com>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "imx@...ts.linux.dev"
	<imx@...ts.linux.dev>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [EXT] Re: [PATCH v10 02/11] arm64: dts: imx8ulp: add usb nodes



> 
> On Thu, Mar 21, 2024 at 04:14:30PM +0800, Xu Yang wrote:
> > Add USB nodes on i.MX8ULP platform which has 2 USB controllers.
> >
> > Signed-off-by: Xu Yang <xu.yang_2@....com>
> >
> > ---
> > Changes in v2:
> >  - no changes
> > Changes in v3:
> >  - no changes
> > Changes in v4:
> >  - no changes
> > Changes in v5:
> >  - no changes
> > Changes in v6:
> >  - drop usbphy aliases
> > Changes in v7:
> >  - no changes
> > Changes in v8:
> >  - no changes
> > Changes in v9:
> >  - no changes
> > Changes in v10:
> >  - no changes
> > ---
> >  arch/arm64/boot/dts/freescale/imx8ulp.dtsi | 62 ++++++++++++++++++++++
> >  1 file changed, 62 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> > index c4a0082f30d3..7da9461a5745 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> > @@ -472,6 +472,68 @@ usdhc2: mmc@...f0000 {
> >                               status = "disabled";
> >                       };
> >
> > +                     usbotg1: usb@...00000 {
> > +                             compatible = "fsl,imx8ulp-usb", "fsl,imx7ulp-usb", "fsl,imx6ul-usb";
> > +                             reg = <0x29900000 0x200>;
> > +                             interrupts = <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>;
> > +                             clocks = <&pcc4 IMX8ULP_CLK_USB0>;
> > +                             power-domains = <&scmi_devpd IMX8ULP_PD_USB0>;
> > +                             phys = <&usbphy1>;
> > +                             fsl,usbmisc = <&usbmisc1 0>;
> > +                             ahb-burst-config = <0x0>;
> > +                             tx-burst-size-dword = <0x8>;
> > +                             rx-burst-size-dword = <0x8>;
> > +                             status = "disabled";
> > +                     };
> > +
> > +                     usbmisc1: usbmisc@...00200 {
> > +                             compatible = "fsl,imx8ulp-usbmisc", "fsl,imx7d-usbmisc",
> > +                                             "fsl,imx6q-usbmisc";
> > +                             #index-cells = <1>;
> > +                             reg = <0x29900200 0x200>;
> 
> Could you move 'reg' above so that it's after compatible?

Okay.

> 
> > +                             status = "disabled";
> > +                     };
> > +
> > +                     usbphy1: usb-phy@...10000 {
> > +                             compatible = "fsl,imx8ulp-usbphy", "fsl,imx7ulp-usbphy";
> > +                             reg = <0x29910000 0x10000>;
> > +                             interrupts = <GIC_SPI 104 IRQ_TYPE_LEVEL_HIGH>;
> > +                             clocks = <&pcc4 IMX8ULP_CLK_USB0_PHY>;
> > +                             #phy-cells = <0>;
> > +                             status = "disabled";
> > +                     };
> > +
> > +                     usbotg2: usb@...20000 {
> > +                             compatible = "fsl,imx8ulp-usb", "fsl,imx7ulp-usb", "fsl,imx6ul-usb";
> > +                             reg = <0x29920000 0x200>;
> > +                             interrupts = <GIC_SPI 105 IRQ_TYPE_LEVEL_HIGH>;
> > +                             clocks = <&pcc4 IMX8ULP_CLK_USB1>;
> > +                             power-domains = <&scmi_devpd IMX8ULP_PD_USDHC2_USB1>;
> > +                             phys = <&usbphy2>;
> > +                             fsl,usbmisc = <&usbmisc2 0>;
> > +                             ahb-burst-config = <0x0>;
> > +                             tx-burst-size-dword = <0x8>;
> > +                             rx-burst-size-dword = <0x8>;
> > +                             status = "disabled";
> > +                     };
> > +
> > +                     usbmisc2: usbmisc@...20200 {
> > +                             compatible = "fsl,imx8ulp-usbmisc", "fsl,imx7d-usbmisc",
> > +                                             "fsl,imx6q-usbmisc";
> > +                             #index-cells = <1>;
> > +                             reg = <0x29920200 0x200>;
> 
> Ditto

Okay.

Thanks,
Xu Yang

> 
> Shawn
> 
> > +                             status = "disabled";
> > +                     };
> > +
> > +                     usbphy2: usb-phy@...30000 {
> > +                             compatible = "fsl,imx8ulp-usbphy", "fsl,imx7ulp-usbphy";
> > +                             reg = <0x29930000 0x10000>;
> > +                             interrupts = <GIC_SPI 106 IRQ_TYPE_LEVEL_HIGH>;
> > +                             clocks = <&pcc4 IMX8ULP_CLK_USB1_PHY>;
> > +                             #phy-cells = <0>;
> > +                             status = "disabled";
> > +                     };
> > +
> >                       fec: ethernet@...50000 {
> >                               compatible = "fsl,imx8ulp-fec", "fsl,imx6ul-fec", "fsl,imx6q-fec";
> >                               reg = <0x29950000 0x10000>;
> > --
> > 2.34.1
> >


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ