linux-kernel - Re: [PATCH] scsi: sd: unregister device if device_add_disk() failed in sd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <171202249157.2135322.13476364200143136492.b4-ty@oracle.com>
Date: Mon,  1 Apr 2024 21:48:36 -0400
From: "Martin K. Petersen" <martin.petersen@...cle.com>
To: jejb@...ux.ibm.com, mcgrof@...nel.org, linan666@...weicloud.com
Cc: "Martin K . Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        linan122@...wei.com, yukuai3@...wei.com, yi.zhang@...wei.com,
        houtao1@...wei.com, yangerkun@...wei.com
Subject: Re: [PATCH] scsi: sd: unregister device if device_add_disk() failed in sd_probe()

On Fri, 08 Dec 2023 16:23:35 +0800, linan666@...weicloud.com wrote:

> "if device_add() succeeds, you should call device_del() when you want to
> get rid of it."
> 
> In sd_probe(), device_add_disk() fails when device_add() has already
> succeeded, so change put_device() to device_unregister() to ensure device
> resources are released.
> 
> [...]

Applied to 6.9/scsi-fixes, thanks!

[1/1] scsi: sd: unregister device if device_add_disk() failed in sd_probe()
      https://git.kernel.org/mkp/scsi/c/0296bea01cfa

-- 
Martin K. Petersen	Oracle Linux Engineering