linux-kernel - Re: [PATCH] LoongArch: KVM: Remove useless MODULE macro for MODULE_DEVICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <31d39556-79d9-52eb-36aa-5897aea6e28e@loongson.cn>
Date: Tue, 2 Apr 2024 19:21:55 +0800
From: maobibo <maobibo@...ngson.cn>
To: Wentao Guan <guanwentao@...ontech.com>, zhaotianrui@...ngson.cn
Cc: loongarch@...ts.linux.dev, linux-kernel@...r.kernel.org,
 Yuli Wang <wangyuli@...ontech.com>
Subject: Re: [PATCH] LoongArch: KVM: Remove useless MODULE macro for
 MODULE_DEVICE_TABLE



On 2024/4/2 下午6:39, Wentao Guan wrote:
> MODULE_DEVICE_TABLE use ifdef MODULE macro in module.h,
> just clean it up.
> 
> Suggested-by: Yuli Wang <wangyuli@...ontech.com>
> Signed-off-by: Wentao Guan <guanwentao@...ontech.com>
> ---
>   arch/loongarch/kvm/main.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/arch/loongarch/kvm/main.c b/arch/loongarch/kvm/main.c
> index 86a2f2d0cb27..7f2bd9a0814c 100644
> --- a/arch/loongarch/kvm/main.c
> +++ b/arch/loongarch/kvm/main.c
> @@ -410,10 +410,8 @@ static void kvm_loongarch_exit(void)
>   module_init(kvm_loongarch_init);
>   module_exit(kvm_loongarch_exit);
>   
> -#ifdef MODULE
>   static const struct cpu_feature kvm_feature[] = {
>   	{ .feature = cpu_feature(LOONGARCH_LVZ) },
>   	{},
>   };
Wentao,

Thanks for your patch, there is static variable kvm_feature
which is embraced by macro MODULE also :-), besides MODULE_DEVICE_TABLE.

Regards
Bibo Mao
>   MODULE_DEVICE_TABLE(cpu, kvm_feature);
> -#endif
>