linux-kernel - Re: Re: [PATCH v9 15/15] selftests/sgx: Add scripts for EPC cgroup testing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <htiz5jgsby5v262saphhomcsxtixb2u7ot6jcghpfhvgz65ht6@qlz3gpdwapaa>
Date: Tue, 2 Apr 2024 13:23:19 +0200
From: Michal Koutný <mkoutny@...e.com>
To: Jarkko Sakkinen <jarkko@...nel.org>
Cc: Haitao Huang <haitao.huang@...ux.intel.com>, 
	dave.hansen@...ux.intel.com, tj@...nel.org, linux-kernel@...r.kernel.org, 
	linux-sgx@...r.kernel.org, x86@...nel.org, cgroups@...r.kernel.org, tglx@...utronix.de, 
	mingo@...hat.com, bp@...en8.de, hpa@...or.com, sohil.mehta@...el.com, 
	tim.c.chen@...ux.intel.com, zhiquan1.li@...el.com, kristen@...ux.intel.com, 
	seanjc@...gle.com, zhanb@...rosoft.com, anakrish@...rosoft.com, 
	mikko.ylinen@...ux.intel.com, yangjie@...rosoft.com, chrisyan@...rosoft.com
Subject: Re: Re: [PATCH v9 15/15] selftests/sgx: Add scripts for EPC cgroup
 testing

Hello.

On Sat, Mar 30, 2024 at 01:26:08PM +0200, Jarkko Sakkinen <jarkko@...nel.org> wrote:
> > > It'd be more complicated and less readable to do all the stuff without the  
> > > cgroup-tools, esp cgexec. I checked dependency, cgroup-tools only depends  
> > > on libc so I hope this would not cause too much inconvenience.
> >
> > As per cgroup-tools, please prove this. It makes the job for more
> > complicated *for you* and you are making the job more  complicated
> > to every possible person in the planet running any kernel QA.
> >
> > I weight the latter more than the former. And it is exactly the
> > reason why we did custom user space kselftest in the first place.
> > Let's keep the tradition. All I can say is that kselftest is 
> > unfinished in its current form.
> >
> > What is "esp cgexec"?
> 
> Also in kselftest we don't drive ultimate simplicity, we drive
> efficient CI/QA. By open coding something like subset of
> cgroup-tools needed to run the test you also help us later
> on to backtrack the kernel changes. With cgroups-tools you
> would have to use strace to get the same info.

FWIW, see also functions in
tools/testing/selftests/cgroup/cgroup_util.{h,c}.
They likely cover what you need already -- if the tests are in C.

(I admit that stuff in tools/testing/selftests/cgroup/ is best
understood with strace.)

HTH,
Michal

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)