linux-kernel - Re: [PATCH v2] HID: i2c-hid: Revert to await reset ACK before reading report descriptor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c5ee5eec-b00e-41b3-bbef-6f0d58d70d66@redhat.com>
Date: Tue, 2 Apr 2024 13:43:33 +0200
From: Hans de Goede <hdegoede@...hat.com>
To: Kenny Levinsen <kl@...wtf>, Jiri Kosina <jikos@...nel.org>,
 Benjamin Tissoires <benjamin.tissoires@...hat.com>
Cc: Douglas Anderson <dianders@...omium.org>, linux-input@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] HID: i2c-hid: Revert to await reset ACK before reading
 report descriptor

Hi,

On 4/2/24 1:30 PM, Kenny Levinsen wrote:
> On 4/2/24 1:06 PM, Hans de Goede wrote:
>> One small remark comment below. In the hope of getting this merged
>> soon I'll prepare a v3 addressing this myself (keeping you as the author).
> 
> 
> A-OK from my side, the abort_reset label is indeed redundant now.
> 
> (The split between start and finish is also technically redundant when we always finish after start, but I wanted to keep the change minimal.)

Right actually for undoing the moving of the finish-reset
you could also have done a straight forward revert:

git revert af93a167eda9

My v3 is pretty close to this, but not exactly a full revert
since I kept your minimal approach.

Undoing the split however does not cleanly revert.

Regards,

Hans