linux-kernel - Re: [PATCH] block: fix overflow in blk_ioctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240402123245.GA30793@lst.de>
Date: Tue, 2 Apr 2024 14:32:45 +0200
From: Christoph Hellwig <hch@....de>
To: linan666@...weicloud.com
Cc: axboe@...nel.dk, hch@....de, linux-block@...r.kernel.org,
	linux-kernel@...r.kernel.org, yukuai3@...wei.com,
	yi.zhang@...wei.com, houtao1@...wei.com, yangerkun@...wei.com
Subject: Re: [PATCH] block: fix overflow in blk_ioctl_discard()

On Fri, Mar 29, 2024 at 09:23:19AM +0800, linan666@...weicloud.com wrote:
> From: Li Nan <linan122@...wei.com>
> 
> There is no check for overflow of 'start + len' in blk_ioctl_discard().
> Hung task occurs if submit an discard ioctl with the following param:
>   start = 0x80000000000ff000, len = 0x8000000000fff000;
> Add the overflow validation now.

Looks good:

Reviewed-by: Christoph Hellwig <hch@....de>

Can you wire up a testcase in blktests for this condition?