linux-kernel - Re: [linus:master] [serial] 43066e3222: BUG:kernel_NULL_pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zg1hBvRAxifo50sf@smile.fi.intel.com>
Date: Wed, 3 Apr 2024 17:00:38 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: kernel test robot <oliver.sang@...el.com>
Cc: Yicong Yang <yangyicong@...ilicon.com>, oe-lkp@...ts.linux.dev,
	lkp@...el.com, linux-kernel@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	stable <stable@...nel.org>, Tony Lindgren <tony@...mide.com>,
	linux-serial@...r.kernel.org
Subject: Re: [linus:master] [serial]  43066e3222:
 BUG:kernel_NULL_pointer_dereference,address

On Wed, Apr 03, 2024 at 09:43:28PM +0800, kernel test robot wrote:

> kernel test robot noticed "BUG:kernel_NULL_pointer_dereference,address" on:
> 
> commit: 43066e32227ecde674e8ae1fcdd4a1ede67680c2 ("serial: port: Don't suspend if the port is still busy")
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master

Ja-ja, I am investigating this issue for a while (not that I spend all my time
on it, though) on max3100.

The problem seems that we enable PM runtime on all serial ports
(even if they have no RPM support), but at the same time we enforce
the common serial_port PM callbacks and that change misses a detail
on how to check the port status as the real callback may happen
quite after the port being closed (/dev/ttySx).

Probably we need to check if the port is still open...

P.S. AFAIU the state / xmit is invalid pointer or so.

Culprit line:	serial_out(up, UART_TX, xmit->buf[xmit->tail]);

-- 
With Best Regards,
Andy Shevchenko