linux-kernel - Re: [PATCH 1/1] hexagon: Don't select GENERIC_IOMAP without HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 03 Apr 2024 17:22:09 +0200
From: Niklas Schnelle <schnelle@...ux.ibm.com>
To: Brian Cain <bcain@...cinc.com>
Cc: "linux-hexagon@...r.kernel.org" <linux-hexagon@...r.kernel.org>,
        Arnd
 Bergmann <arnd@...nel.org>, Heiko Carstens <hca@...ux.ibm.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] hexagon: Don't select GENERIC_IOMAP without
 HAS_IOPORT support

On Wed, 2024-04-03 at 14:51 +0000, Brian Cain wrote:
> 
> > -----Original Message-----
> > From: Niklas Schnelle <schnelle@...ux.ibm.com>
> > Sent: Wednesday, April 3, 2024 8:25 AM
> > To: Brian Cain <bcain@...cinc.com>
> > Cc: linux-hexagon@...r.kernel.org; Arnd Bergmann <arnd@...nel.org>;
> > Heiko Carstens <hca@...ux.ibm.com>; linux-kernel@...r.kernel.org; Niklas
> > Schnelle <schnelle@...ux.ibm.com>
> > Subject: [PATCH 1/1] hexagon: Don't select GENERIC_IOMAP without
> > HAS_IOPORT support
> > 
> > WARNING: This email originated from outside of Qualcomm. Please be wary
> > of any links or attachments, and do not enable macros.
> > 
> > In a future patch HAS_IOPORT=n will disable inb()/outb() and friends at
> > compile time. As hexagon does not support I/O port access it also
> > the GENERIC_IOMAP mechanism of dynamically choosing between I/O port
> > and
> > MMIO access doesn't work so don't select it.
> > 
> > Co-developed-by: Arnd Bergmann <arnd@...nel.org>
> > Signed-off-by: Arnd Bergmann <arnd@...nel.org>
> > Signed-off-by: Niklas Schnelle <schnelle@...ux.ibm.com>
> > ---
> >  arch/hexagon/Kconfig | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/arch/hexagon/Kconfig b/arch/hexagon/Kconfig
> > index e233b5efa276..5ea1bf4b7d4f 100644
> > --- a/arch/hexagon/Kconfig
> > +++ b/arch/hexagon/Kconfig
> > @@ -31,7 +31,6 @@ config HEXAGON
> >         select HAVE_ARCH_TRACEHOOK
> >         select NEED_SG_DMA_LENGTH
> >         select NO_IOPORT_MAP
> > -       select GENERIC_IOMAP
> >         select GENERIC_IOREMAP
> >         select GENERIC_SMP_IDLE_THREAD
> >         select STACKTRACE_SUPPORT
> 
> Reviewed-by: Brian Cain <bcain@...cinc.com>
> 

Thanks for the R-b, which tree should take this? If you have other
hexagon changes for v6.10 I think it would be easiest to take this
together with those. As mentioned in the cover letter the per-subsystem
changes are all independent until HAS_IOPORT=n actually disables
inb()/outb() which Arnd will take once all the subsystems are covered.

Thanks,
Niklas