linux-kernel - Re: [PATCH v2] USB: Convert from tasklet to BH workqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOMdWS+Z1ZS2VPBXiYbtOyYBuCCx1i8M1aVMYHGhMRTv259xaA@mail.gmail.com>
Date: Wed, 3 Apr 2024 08:40:23 -0700
From: Allen <allen.lkml@...il.com>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: Allen Pais <apais@...ux.microsoft.com>, linux-kernel@...r.kernel.org, tj@...nel.org, 
	keescook@...omium.org, duncan.sands@...e.fr, stern@...land.harvard.edu, 
	mathias.nyman@...el.com, oneukum@...e.com, linux-usb@...r.kernel.org
Subject: Re: [PATCH v2] USB: Convert from tasklet to BH workqueue

On Wed, Apr 3, 2024 at 8:02 AM Greg KH <gregkh@...uxfoundation.org> wrote:
>
> On Wed, Apr 03, 2024 at 02:38:52PM +0000, Allen Pais wrote:
> > The only generic interface to execute asynchronously in the BH context is
> > tasklet; however, it's marked deprecated and has some design flaws. To
> > replace tasklets, BH workqueue support was recently added. A BH workqueue
> > behaves similarly to regular workqueues except that the queued work items
> > are executed in the BH context.
> >
> > This patch converts drivers/usb/* from tasklet to BH workqueue.
> >
> > Based on the work done by Tejun Heo <tj@...nel.org>
> > Branch: https://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git for-610
> >
> > Changes in v2:
> >  - Update code comments and commit message.
> >       Suggested by Greg K h
> >  - Retain local variable name(hcd.c).
> >       Suggested by Alan Stern
> >
> > Link to v1:https://lore.kernel.org/all/20240327160314.9982-1
> > -apais@...ux.microsoft.com/T/#m2ec7868fbf102f1551ebe4c92d200848b94af3b1
>
> Why the line-wrap?
>
> And v2 info should all go below the --- line, right?
>
> v3 perhaps?

 I missed that bit. I will send out a v3.

Thank you.