linux-kernel - Re: Implementing .shutdown method for efa module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240403154414.GD1363414@ziepe.ca>
Date: Wed, 3 Apr 2024 12:44:14 -0300
From: Jason Gunthorpe <jgg@...pe.ca>
To: "Margolin, Michael" <mrgolin@...zon.com>
Cc: Tao Liu <ltao@...hat.com>, Gal Pressman <gal.pressman@...ux.dev>,
	sleybo@...zon.com, leon@...nel.org, kexec@...ts.infradead.org,
	linux-kernel@...r.kernel.org, linux-rdma@...r.kernel.org
Subject: Re: Implementing .shutdown method for efa module

On Mon, Apr 01, 2024 at 04:23:32PM +0300, Margolin, Michael wrote:
> Jason
> 
> Thanks for your response, efa_remove() is performing reset to the device
> which should stop all DMA from the device.
> 
> Except skipping cleanups that are unnecessary for shutdown flow are there
> any other reasons to prefer a separate function for shutdown?

Yes you should skip "cleanups" like removing the IB device and
otherwise as there is a risk of system hang/deadlock in a shutdown
handler context.

Jason