linux-kernel - Re: [PATCH v0 01/14] IB/hfi1, IB/qib: Make I2C terminology more inclusive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0214214a-73c4-46b4-a099-189036954aa1@cornelisnetworks.com>
Date: Wed, 3 Apr 2024 11:54:52 -0400
From: Dennis Dalessandro <dennis.dalessandro@...nelisnetworks.com>
To: Leon Romanovsky <leon@...nel.org>,
 Easwar Hariharan <eahariha@...ux.microsoft.com>
Cc: Jason Gunthorpe <jgg@...pe.ca>,
 "open list:HFI1 DRIVER" <linux-rdma@...r.kernel.org>,
 open list <linux-kernel@...r.kernel.org>,
 Wolfram Sang <wsa+renesas@...g-engineering.com>,
 "open list:RADEON and AMDGPU DRM DRIVERS" <amd-gfx@...ts.freedesktop.org>,
 "open list:DRM DRIVERS" <dri-devel@...ts.freedesktop.org>,
 "open list:INTEL DRM DISPLAY FOR XE AND I915 DRIVERS"
 <intel-gfx@...ts.freedesktop.org>,
 "open list:INTEL DRM DISPLAY FOR XE AND I915 DRIVERS"
 <intel-xe@...ts.freedesktop.org>,
 "open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS"
 <nouveau@...ts.freedesktop.org>,
 "open list:I2C SUBSYSTEM HOST DRIVERS" <linux-i2c@...r.kernel.org>,
 "open list:BTTV VIDEO4LINUX DRIVER" <linux-media@...r.kernel.org>,
 "open list:FRAMEBUFFER LAYER" <linux-fbdev@...r.kernel.org>
Subject: Re: [PATCH v0 01/14] IB/hfi1, IB/qib: Make I2C terminology more
 inclusive


On 4/3/24 4:30 AM, Leon Romanovsky wrote:
> On Fri, Mar 29, 2024 at 05:00:25PM +0000, Easwar Hariharan wrote:
>> I2C v7, SMBus 3.2, and I3C specifications have replaced "master/slave"
>> with more appropriate terms. Inspired by and following on to Wolfram's series
>> to fix drivers/i2c[1], fix the terminology where I had a role to play, now that
>> the approved verbiage exists in the specification.
>>
>> Compile tested, no functionality changes intended
>>
>> [1]: https://lore.kernel.org/all/20240322132619.6389-1-wsa+renesas@sang-engineering.com/
>>
>> Signed-off-by: Easwar Hariharan <eahariha@...ux.microsoft.com>
>> ---
>>  drivers/infiniband/hw/hfi1/chip.c           |  6 ++--
>>  drivers/infiniband/hw/hfi1/chip.h           |  2 +-
>>  drivers/infiniband/hw/hfi1/chip_registers.h |  2 +-
>>  drivers/infiniband/hw/hfi1/file_ops.c       |  2 +-
>>  drivers/infiniband/hw/hfi1/firmware.c       | 22 ++++++-------
>>  drivers/infiniband/hw/hfi1/pcie.c           |  2 +-
>>  drivers/infiniband/hw/hfi1/qsfp.c           | 36 ++++++++++-----------
>>  drivers/infiniband/hw/hfi1/user_exp_rcv.c   |  2 +-
>>  drivers/infiniband/hw/qib/qib_twsi.c        |  6 ++--
>>  9 files changed, 40 insertions(+), 40 deletions(-)
> 
> hfi1 and qib work perfectly fine with the current terminology. There is
> no need to change old code just for the sake of change.
> 
> Let's drop this patch.

Agreed.