linux-kernel - Re: [PATCH 2/3] ARM: dts: Disable unused ADC channels for Asrock X570D4U BMC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <42e91dc2bccdcac96abd729def8a05b2612488a7.camel@codeconstruct.com.au>
Date: Wed, 03 Apr 2024 13:59:17 +1030
From: Andrew Jeffery <andrew@...econstruct.com.au>
To: Renze Nicolai <renze@...lus.nl>, linux-arm-kernel@...ts.infradead.org, 
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
 linux-aspeed@...ts.ozlabs.org, arnd@...db.de, olof@...om.net,
 soc@...nel.org,  robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
 joel@....id.au,  andrew@...id.au
Subject: Re: [PATCH 2/3] ARM: dts: Disable unused ADC channels for Asrock
 X570D4U BMC

Hi Renze,

On Fri, 2024-03-29 at 14:01 +0100, Renze Nicolai wrote:
> This commit disables unused ADC channels and labels the ADC channels used with their function.

Please run this through checkpatch and address the warnings.

Also, the submitting patches documentation[1] suggests using the
imperative mood - instead of "This commit disables ...", use "Disable
..". The change subject is phrased the expected way.

[1]: https://docs.kernel.org/process/submitting-patches.html

Taking the subject and the description together, the description feels
a little redundant. Maybe it could be trimmed back to

> Also, label the ADC channels used with their function.

Andrew