linux-kernel - Re: [PATCH v15 2/9] f2fs: Simplify the handling of cached insensitive names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240403033055.GD2576@sol.localdomain>
Date: Tue, 2 Apr 2024 20:30:55 -0700
From: Eric Biggers <ebiggers@...nel.org>
To: Eugen Hristev <eugen.hristev@...labora.com>
Cc: tytso@....edu, adilger.kernel@...ger.ca, linux-ext4@...r.kernel.org,
	jaegeuk@...nel.org, chao@...nel.org,
	linux-f2fs-devel@...ts.sourceforge.net,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel@...labora.com, viro@...iv.linux.org.uk, brauner@...nel.org,
	jack@...e.cz, krisman@...e.de,
	Gabriel Krisman Bertazi <krisman@...labora.com>
Subject: Re: [PATCH v15 2/9] f2fs: Simplify the handling of cached
 insensitive names

On Tue, Apr 02, 2024 at 06:48:35PM +0300, Eugen Hristev wrote:
> diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c
> index d0f24ccbd1ac..7e53abf6d216 100644
> --- a/fs/f2fs/recovery.c
> +++ b/fs/f2fs/recovery.c
> @@ -153,11 +153,8 @@ static int init_recovered_filename(const struct inode *dir,
>  		if (err)
>  			return err;
>  		f2fs_hash_filename(dir, fname);
> -#if IS_ENABLED(CONFIG_UNICODE)
>  		/* Case-sensitive match is fine for recovery */
> -		kmem_cache_free(f2fs_cf_name_slab, fname->cf_name.name);
> -		fname->cf_name.name = NULL;
> -#endif
> +		f2fs_free_casefolded_name(fname);
>  	} else {
>  		f2fs_hash_filename(dir, fname);
>  	}

This change makes the declaration of f2fs_cf_name_slab in recovery.c
unnecessary.  It can be removed.

- Eric