linux-kernel - Re: [PATCH] ata: sata_gemini: Add check for clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <679e665c-73cf-4dfb-ad86-efc799b3f8e3@kernel.org>
Date: Wed, 3 Apr 2024 12:56:17 +0900
From: Damien Le Moal <dlemoal@...nel.org>
To: Chen Ni <nichen@...as.ac.cn>, linus.walleij@...aro.org, cassel@...nel.org
Cc: linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ata: sata_gemini: Add check for clk_enable

On 4/3/24 12:43, Chen Ni wrote:
> As the potential failure of the clk_enable(), it should be better to
> check it and return error if fails.

Simplify please:

The call to clk_enable() in gemini_sata_start_bridge() can fail. Add a check to
detect such failure.

> 
> Signed-off-by: Chen Ni <nichen@...as.ac.cn>
> ---
>  drivers/ata/sata_gemini.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/ata/sata_gemini.c b/drivers/ata/sata_gemini.c
> index 400b22ee99c3..4c270999ba3c 100644
> --- a/drivers/ata/sata_gemini.c
> +++ b/drivers/ata/sata_gemini.c
> @@ -200,7 +200,10 @@ int gemini_sata_start_bridge(struct sata_gemini *sg, unsigned int bridge)
>  		pclk = sg->sata0_pclk;
>  	else
>  		pclk = sg->sata1_pclk;
> -	clk_enable(pclk);
> +	ret = clk_enable(pclk);
> +	if (ret)
> +		return ret;
> +
>  	msleep(10);
>  
>  	/* Do not keep clocking a bridge that is not online */

-- 
Damien Le Moal
Western Digital Research