linux-kernel - Re: [PATCH v2] Documentation: kunit: Clarify test filter format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGS_qxpBmmafnQnDXYf5RftPzxghd+i8Ly4CK=EkcpidpCPP6g@mail.gmail.com>
Date: Wed, 3 Apr 2024 14:59:43 -0700
From: Daniel Latypov <dlatypov@...gle.com>
To: Brendan Jackman <jackmanb@...gle.com>
Cc: linux-kselftest@...r.kernel.org, kunit-dev@...glegroups.com, 
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Brendan Higgins <brendan.higgins@...ux.dev>, davidgow@...gle.com, rmoar@...gle.com, 
	corbet@....net
Subject: Re: [PATCH v2] Documentation: kunit: Clarify test filter format

On Tue, Apr 2, 2024 at 5:51 AM Brendan Jackman <jackmanb@...gle.com> wrote:
>
> It seems obvious once you know, but at first I didn't realise that the
> suite name is part of this format. Document it and add some examples.
>
> Signed-off-by: Brendan Jackman <jackmanb@...gle.com>

Reviewed-by: Daniel Latypov <dlatypov@...gle.com>

Thanks!

I agree with your comment on v1, I think the extra verbosity is fine.
It's still easy to read and this should hopefully eliminate the
ambiguity for most readers.

> ---
> v1->v2: Expanded to clarify that suite_glob and test_glob are two separate
>         patterns. Also made some other trivial changes to formatting etc.

<snip>