[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20240403043349.3623961-1-nichen@iscas.ac.cn>
Date: Wed, 3 Apr 2024 04:33:49 +0000
From: Chen Ni <nichen@...as.ac.cn>
To: linus.walleij@...aro.org,
dlemoal@...nel.org,
cassel@...nel.org
Cc: linux-ide@...r.kernel.org,
linux-kernel@...r.kernel.org,
Chen Ni <nichen@...as.ac.cn>
Subject: [PATCH v2] ata: sata_gemini: Add check for clk_enable
The call to clk_enable() in gemini_sata_start_bridge() can fail.
Add a check to detect such failure.
Signed-off-by: Chen Ni <nichen@...as.ac.cn>
---
Changelog:
v1 -> v2:
1. Simplify commit message
---
drivers/ata/sata_gemini.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/ata/sata_gemini.c b/drivers/ata/sata_gemini.c
index 400b22ee99c3..4c270999ba3c 100644
--- a/drivers/ata/sata_gemini.c
+++ b/drivers/ata/sata_gemini.c
@@ -200,7 +200,10 @@ int gemini_sata_start_bridge(struct sata_gemini *sg, unsigned int bridge)
pclk = sg->sata0_pclk;
else
pclk = sg->sata1_pclk;
- clk_enable(pclk);
+ ret = clk_enable(pclk);
+ if (ret)
+ return ret;
+
msleep(10);
/* Do not keep clocking a bridge that is not online */
--
2.25.1
Powered by blists - more mailing lists