linux-kernel - Re: [PATCH v4 2/3] VT: Add KDFONTINFO ioctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024040306-unleash-scrubbed-1c2b@gregkh>
Date: Wed, 3 Apr 2024 06:55:08 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Alexey Gladkov <legion@...nel.org>
Cc: Jiri Slaby <jirislaby@...nel.org>, LKML <linux-kernel@...r.kernel.org>,
	kbd@...ts.linux.dev, linux-api@...r.kernel.org,
	linux-fbdev@...r.kernel.org, linux-serial@...r.kernel.org,
	Helge Deller <deller@....de>
Subject: Re: [PATCH v4 2/3] VT: Add KDFONTINFO ioctl

On Tue, Apr 02, 2024 at 07:50:45PM +0200, Alexey Gladkov wrote:
> +struct console_font_info {
> +	unsigned int min_width, min_height;	/* minimal font size */
> +	unsigned int max_width, max_height;	/* maximum font size */
> +	unsigned int flags;			/* KD_FONT_INFO_FLAG_* */
> +};

As Jiri said, this will not work for an ioctl structure at all, sorry.
Please read the kernel documentation about how to write a new ioctl for
how to do this correctly (hint, you can not use 'unsigned int' in a
structure that crosses the kernel/user boundry for new ioctls.)

thanks,

greg k-h