linux-kernel - Re: [PATCH 2/2] drm/panthor: Fix some kerneldoc warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240403084632.1d00d1c6@collabora.com>
Date: Wed, 3 Apr 2024 08:46:32 +0200
From: Boris Brezillon <boris.brezillon@...labora.com>
To: Liviu Dudau <liviu.dudau@....com>
Cc: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard
 <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, Steven Price
 <steven.price@....com>
Subject: Re: [PATCH 2/2] drm/panthor: Fix some kerneldoc warnings

On Tue,  2 Apr 2024 22:54:23 +0100
Liviu Dudau <liviu.dudau@....com> wrote:

> When compiling with W=1 the build process will flag empty comments,
> misnamed documented variables and incorrect tagging of functions.
> Fix them in one go.
> 
> Fixes: de8548813824 ("drm/panthor: Add the scheduler logical block")
> Cc: Boris Brezillon <boris.brezillon@...labora.com>
> Cc: Steven Price <steven.price@....com>
> Signed-off-by: Liviu Dudau <liviu.dudau@....com>

Reviewed-by: Boris Brezillon <boris.brezillon@...labora.com>

> ---
>  drivers/gpu/drm/panthor/panthor_sched.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panthor/panthor_sched.c b/drivers/gpu/drm/panthor/panthor_sched.c
> index e5a710f190d2a8..a787f2fea33e98 100644
> --- a/drivers/gpu/drm/panthor/panthor_sched.c
> +++ b/drivers/gpu/drm/panthor/panthor_sched.c
> @@ -517,7 +517,7 @@ struct panthor_group {
>  	/** @max_compute_cores: Maximum number of shader cores used for compute jobs. */
>  	u8 max_compute_cores;
>  
> -	/** @max_compute_cores: Maximum number of shader cores used for fragment jobs. */
> +	/** @max_fragment_cores: Maximum number of shader cores used for fragment jobs. */
>  	u8 max_fragment_cores;
>  
>  	/** @max_tiler_cores: Maximum number of tiler cores used for tiler jobs. */
> @@ -993,7 +993,7 @@ cs_slot_prog_locked(struct panthor_device *ptdev, u32 csg_id, u32 cs_id)
>  }
>  
>  /**
> - * @cs_slot_reset_locked() - Reset a queue slot
> + * cs_slot_reset_locked() - Reset a queue slot
>   * @ptdev: Device.
>   * @csg_id: Group slot.
>   * @cs_id: Queue slot.
> @@ -1591,7 +1591,7 @@ static void sched_process_idle_event_locked(struct panthor_device *ptdev)
>  }
>  
>  /**
> - * panthor_sched_process_global_irq() - Process the scheduling part of a global IRQ
> + * sched_process_global_irq_locked() - Process the scheduling part of a global IRQ
>   * @ptdev: Device.
>   */
>  static void sched_process_global_irq_locked(struct panthor_device *ptdev)
> @@ -1660,8 +1660,6 @@ static const struct dma_fence_ops panthor_queue_fence_ops = {
>  	.get_timeline_name = queue_fence_get_timeline_name,
>  };
>  
> -/**
> - */
>  struct panthor_csg_slots_upd_ctx {
>  	u32 update_mask;
>  	u32 timedout_mask;