linux-kernel - Re: [Linux-stm32] [PATCH net-next 2/2] net: stmmac: dwmac-socfpga: use pcs_init/pcs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 3 Apr 2024 10:12:26 +0200
From: Maxime Chevallier <maxime.chevallier@...tlin.com>
To: "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>
Cc: Romain Gantois <romain.gantois@...tlin.com>, Rob Herring
 <robh@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Maxime Coquelin
 <mcoquelin.stm32@...il.com>, Geert Uytterhoeven <geert+renesas@...der.be>,
 devicetree@...r.kernel.org, Thomas Petazzoni
 <thomas.petazzoni@...tlin.com>, netdev@...r.kernel.org,
 linux-stm32@...md-mailman.stormreply.com, Magnus Damm
 <magnus.damm@...il.com>, linux-kernel@...r.kernel.org,
 linux-renesas-soc@...r.kernel.org, Eric Dumazet <edumazet@...gle.com>, Jose
 Abreu <joabreu@...opsys.com>, Krzysztof Kozlowski
 <krzysztof.kozlowski+dt@...aro.org>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Clément Léger
 <clement.leger@...tlin.com>, "David S. Miller" <davem@...emloft.net>,
 linux-arm-kernel@...ts.infradead.org
Subject: Re: [Linux-stm32] [PATCH net-next 2/2] net: stmmac: dwmac-socfpga:
 use pcs_init/pcs_exit

Hello Russell,

On Tue, 02 Apr 2024 16:51:48 +0100
"Russell King (Oracle)" <rmk+kernel@...linux.org.uk> wrote:

> Use the newly introduced pcs_init() and pcs_exit() operations to
> create and destroy the PCS instance at a more appropriate moment during
> the driver lifecycle, thereby avoiding publishing a network device to
> userspace that has not yet finished its PCS initialisation.
> 
> There are other similar issues with this driver which remain
> unaddressed, but these are out of scope for this patch.
> 
> Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>

Thanks for addressing this,

Reviewed-by: Maxime Chevallier <maxime.chevallier@...tlin.com>