linux-kernel - Re: [PATCH v9 07/21] virt: geniezone: Add vm capability check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <27258baa96e7ff3701ee56e86dd649756da2c70c.camel@mediatek.com>
Date: Wed, 3 Apr 2024 08:50:00 +0000
From: Yi-De Wu (吳一德) <Yi-De.Wu@...iatek.com>
To: "corbet@....net" <corbet@....net>, "robh+dt@...nel.org"
	<robh+dt@...nel.org>, "catalin.marinas@....com" <catalin.marinas@....com>,
	"conor+dt@...nel.org" <conor+dt@...nel.org>, "richardcochran@...il.com"
	<richardcochran@...il.com>, Yingshiuan Pan (潘穎軒)
	<Yingshiuan.Pan@...iatek.com>, "krzysztof.kozlowski+dt@...aro.org"
	<krzysztof.kozlowski+dt@...aro.org>, "matthias.bgg@...il.com"
	<matthias.bgg@...il.com>, Ze-yu Wang (王澤宇)
	<Ze-yu.Wang@...iatek.com>, "angelogioacchino.delregno@...labora.com"
	<angelogioacchino.delregno@...labora.com>, "will@...nel.org"
	<will@...nel.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	"quic_tsoni@...cinc.com" <quic_tsoni@...cinc.com>,
	MY Chuang (莊明躍) <MY.Chuang@...iatek.com>,
	Kevenny Hsieh (謝宜芸)
	<Kevenny.Hsieh@...iatek.com>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, PeiLun Suei (隋培倫)
	<PeiLun.Suei@...iatek.com>, Liju-clr Chen (陳麗如)
	<Liju-clr.Chen@...iatek.com>, "dbrazdil@...gle.com" <dbrazdil@...gle.com>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, Shawn Hsiao (蕭志祥)
	<shawn.hsiao@...iatek.com>, "linux-doc@...r.kernel.org"
	<linux-doc@...r.kernel.org>, Chi-shen Yeh (葉奇軒)
	<Chi-shen.Yeh@...iatek.com>
Subject: Re: [PATCH v9 07/21] virt: geniezone: Add vm capability check

On Thu, 2024-02-01 at 10:44 +0100, AngeloGioacchino Del Regno wrote:
> Il 29/01/24 09:32, Yi-De Wu ha scritto:
> > From: "Yingshiuan Pan" <yingshiuan.pan@...iatek.com>
> > 
> > Inquire the `capability support` on GenieZone hypervisor.
> > Example:
> > `GZVM_CAP_PROTECTED_VM` or `GZVM_CAP_VM_GPA_SIZE`.
> > 
> > Signed-off-by: Yingshiuan Pan <yingshiuan.pan@...iatek.com>
> > Signed-off-by: Jerry Wang <ze-yu.wang@...iatek.com>
> > Signed-off-by: kevenny hsieh <kevenny.hsieh@...iatek.com>
> > Signed-off-by: Liju Chen <liju-clr.chen@...iatek.com>
> > Signed-off-by: Yi-De Wu <yi-de.wu@...iatek.com>
> > ---
> >   arch/arm64/geniezone/gzvm_arch_common.h |   2 +
> >   arch/arm64/geniezone/vm.c               | 122
> > ++++++++++++++++++++++++
> >   drivers/virt/geniezone/gzvm_main.c      |  27 ++++++
> >   drivers/virt/geniezone/gzvm_vm.c        |  21 ++++
> >   include/linux/gzvm_drv.h                |   5 +
> >   include/uapi/linux/gzvm.h               |  31 ++++++
> >   6 files changed, 208 insertions(+)
> > 
> > diff --git a/arch/arm64/geniezone/gzvm_arch_common.h
> > b/arch/arm64/geniezone/gzvm_arch_common.h
> > index 2f66e496dfae..383af0829f11 100644
> > --- a/arch/arm64/geniezone/gzvm_arch_common.h
> > +++ b/arch/arm64/geniezone/gzvm_arch_common.h
> > @@ -13,6 +13,7 @@ enum {
> >   	GZVM_FUNC_DESTROY_VM = 1,
> >   	GZVM_FUNC_SET_MEMREGION = 4,
> >   	GZVM_FUNC_PROBE = 12,
> > +	GZVM_FUNC_ENABLE_CAP = 13,
> 
> GZVM_FUNC_PROBE  = 12,
> GZVM_FUNC_ENABLE_CAP,
> 

Given that this is an API from the kernel to the hypervisor, it may be
utilized with various toolchains. Our intention is to explicitly assign
values to prevent any unexpected compiler behavior. For further
details, we'd like to refer to the discussion below.

https://lore.kernel.org/all/20200318125003.GA2727094@kroah.com/

> >   	NR_GZVM_FUNC,
> >   };
> >   
> 
> Regards,
> Angelo
>