linux-kernel - Re: [PATCH v1] ALSA: hda/tas2781: correct the register for pow calibrated data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zg0pwtuQ9gfeXwxd@smile.fi.intel.com>
Date: Wed, 3 Apr 2024 13:04:50 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Shenghao Ding <shenghao-ding@...com>
Cc: broonie@...nel.org, lgirdwood@...il.com, perex@...ex.cz,
	pierre-louis.bossart@...ux.intel.com, 13916275206@....com,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
	liam.r.girdwood@...el.com, bard.liao@...el.com,
	yung-chuan.liao@...ux.intel.com, kevin-lu@...com, tiwai@...e.de,
	baojun.xu@...com, soyer@....hu, Baojun.Xu@....com, navada@...com,
	v-po@...com
Subject: Re: [PATCH v1] ALSA: hda/tas2781: correct the register for pow
 calibrated data

On Wed, Apr 03, 2024 at 07:12:59AM +0800, Shenghao Ding wrote:
> fixed tas2781 calibrated data - pow was written into a wrong register.

fixed --> Fix

Fixes tag?

> Signed-off-by: Shenghao Ding <shenghao-ding@...com>

..

> +		0x17, 0x18, 0x18, 0x13, 0x18
> +		0x74, 0x0c, 0x14, 0x70, 0x7c

While at it, can you add a trailing comma?
It will help in case of extending this in the future.

-- 
With Best Regards,
Andy Shevchenko