linux-kernel - Re: [PATCH v4 2/3] serial: 8250_port: Add support of pnp irq to __uart_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 3 Apr 2024 13:06:22 +0300
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Guanbing Huang <albanhuang@...look.com>
Cc: gregkh@...uxfoundation.org, rafael.j.wysocki@...el.com,
	linux-acpi@...r.kernel.org, tony@...mide.com,
	john.ogness@...utronix.de, yangyicong@...ilicon.com,
	jirislaby@...nel.org, linux-kernel@...r.kernel.org,
	linux-serial@...r.kernel.org, lvjianmin@...ngson.cn,
	albanhuang@...cent.com, tombinfan@...cent.com
Subject: Re: [PATCH v4 2/3] serial: 8250_port: Add support of pnp irq to
 __uart_read_properties()

On Wed, Apr 03, 2024 at 12:54:19PM +0300, Andy Shevchenko wrote:
> On Wed, Apr 03, 2024 at 03:41:29PM +0800, Guanbing Huang wrote:


One more thing, the Subject should start with "serial: port: ..."
And also should have PNP IRQ (capitalized).

> > The function __uart_read_properties doesn't cover pnp devices, so add irq
> 
> __uart_read_properties()
> 
> PNP
> IRQ
> 
> > processing for pnp devices in the branch.
> 
> PNP
> 
> ...
> 
> >  #include <linux/property.h>
> >  #include <linux/serial_core.h>
> >  #include <linux/spinlock.h>
> > +#include <linux/pnp.h>
> 
> Keep it ordered (in this context it should go before property.h).

-- 
With Best Regards,
Andy Shevchenko