linux-kernel - Re: [PATCH v2 3/3] usb: typec: displayport: drop driver owner assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 3 Apr 2024 13:26:18 +0300
From: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Ran Wang <ran.wang_1@....com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/3] usb: typec: displayport: drop driver owner
 assignment

On Sun, Mar 31, 2024 at 11:17:37AM +0200, Krzysztof Kozlowski wrote:
> Core in typec_altmode_register_driver() already sets the .owner, so
> driver does not need to.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>

Reviewed-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>

> ---
> 
> Changes in v2:
> 1. New patch
> ---
>  drivers/usb/typec/altmodes/displayport.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/usb/typec/altmodes/displayport.c b/drivers/usb/typec/altmodes/displayport.c
> index 038dc51f429d..596cd4806018 100644
> --- a/drivers/usb/typec/altmodes/displayport.c
> +++ b/drivers/usb/typec/altmodes/displayport.c
> @@ -802,7 +802,6 @@ static struct typec_altmode_driver dp_altmode_driver = {
>  	.remove = dp_altmode_remove,
>  	.driver = {
>  		.name = "typec_displayport",
> -		.owner = THIS_MODULE,
>  		.dev_groups = displayport_groups,
>  	},
>  };
> -- 
> 2.34.1

-- 
heikki