linux-kernel - Re: [PATCH v3 RESEND] HID: nintendo: use ida for LED player id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.2404031326430.20263@cbobk.fhfr.pm>
Date: Wed, 3 Apr 2024 13:26:52 +0200 (CEST)
From: Jiri Kosina <jikos@...nel.org>
To: Martino Fontana <tinozzo123@...il.com>
cc: djogorchock@...il.com, benjamin.tissoires@...hat.com, 
    linux-input@...r.kernel.org, linux-kernel@...r.kernel.org, 
    Ryan McClelland <rymcclel@...il.com>
Subject: Re: [PATCH v3 RESEND] HID: nintendo: use ida for LED player id

On Mon, 18 Mar 2024, Martino Fontana wrote:

> Previously, the leds pattern would just increment with every controller
> connected. This wouldn't take into consideration when controllers are
> disconnected. The same controller could be connected and disconnected
> with the pattern increasing player count each time.
> 
> This patch changes it by using an ID allocator in order to assign the
> player id, the same way hid-playstation does.
> 
> Signed-off-by: Martino Fontana <tinozzo123@...il.com>
> Signed-off-by: Ryan McClelland <rymcclel@...il.com>
> ---
> Changes for v2:
> 
> ida_free now frees the correct id, instead of an id that got moduloed.
> 
> Changes for v3:
> 
> Destroy allocator when removing driver.

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs