linux-kernel - Re: [PATCH v5] hid-ft260: Add serial driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.2404031332560.20263@cbobk.fhfr.pm>
Date: Wed, 3 Apr 2024 13:34:50 +0200 (CEST)
From: Jiri Kosina <jikos@...nel.org>
To: Christina Quast <contact@...istina-quast.de>
cc: Benjamin Tissoires <benjamin.tissoires@...hat.com>, 
    linux-i2c@...r.kernel.org, linux-input@...r.kernel.org, 
    linux-kernel@...r.kernel.org, equinox@...c24.net, 
    Daniel Beer <daniel.beer@...rinstitute.com>, 
    Michael Zaidman <michael.zaidman@...il.com>
Subject: Re: [PATCH v5] hid-ft260: Add serial driver

On Fri, 16 Feb 2024, Christina Quast wrote:

> Adds the serial driver for FT260 USB HID devices, providing direct and
> simplified access to UART functionality without the need for FT260 HID
> report format knowledge.
> 
> This chip implements an UART and I2C interface, but only the latter was
> previously supported with a kernel driver. For the UART interface, only
> FTDI example code using hidraw from userspace was available.
> 
> This commit adds a serial interface /dev/ttyFTx (FT as in FT260), which
> implements tty serial driver ops, facilitating baudrate configuration,
> data transmission and reception, termios settings.

I don't see a dependency on CONFIG_TTY being added, and I believe it 
should be there (even though !CONFIG_TTY configurations are likely 
super-rare).

Thanks,

-- 
Jiri Kosina
SUSE Labs