linux-kernel - Re: [PATCH] block: fix overflow in blk_ioctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cd04226f-4fa8-4e43-70d0-b8707d50f4a3@huaweicloud.com>
Date: Wed, 3 Apr 2024 09:28:36 +0800
From: Li Nan <linan666@...weicloud.com>
To: Christoph Hellwig <hch@....de>, linan666@...weicloud.com
Cc: axboe@...nel.dk, linux-block@...r.kernel.org,
 linux-kernel@...r.kernel.org, yukuai3@...wei.com, yi.zhang@...wei.com,
 houtao1@...wei.com, yangerkun@...wei.com
Subject: Re: [PATCH] block: fix overflow in blk_ioctl_discard()



在 2024/4/2 20:32, Christoph Hellwig 写道:
> On Fri, Mar 29, 2024 at 09:23:19AM +0800, linan666@...weicloud.com wrote:
>> From: Li Nan <linan122@...wei.com>
>>
>> There is no check for overflow of 'start + len' in blk_ioctl_discard().
>> Hung task occurs if submit an discard ioctl with the following param:
>>    start = 0x80000000000ff000, len = 0x8000000000fff000;
>> Add the overflow validation now.
> 
> Looks good:
> 
> Reviewed-by: Christoph Hellwig <hch@....de>
> 
> Can you wire up a testcase in blktests for this condition?
> 

It's my pleasure, I will add testcase later.

> 
> .

-- 
Thanks,
Nan