linux-kernel - RE: [PATCH v2 1/2] Revert "mei: vsc: Call wake

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 3 Apr 2024 12:00:28 +0000
From: "Winkler, Tomas" <tomas.winkler@...el.com>
To: "Wu, Wentong" <wentong.wu@...el.com>, "sakari.ailus@...ux.intel.com"
	<sakari.ailus@...ux.intel.com>, "gregkh@...uxfoundation.org"
	<gregkh@...uxfoundation.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "Yao, Hao"
	<hao.yao@...el.com>, "stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: RE: [PATCH v2 1/2] Revert "mei: vsc: Call wake_up() in the threaded
 IRQ handler"

> handler"
> 
> From: Sakari Ailus <sakari.ailus@...ux.intel.com>
> 
> This reverts commit 058a38acba15fd8e7b262ec6e17c4204cb15f984.
> 
> It's not necessary to avoid a spinlock, a sleeping lock on PREEMPT_RT, in an
> interrupt handler as the interrupt handler itself would be called in a process
> context if PREEMPT_RT is enabled. So revert the patch.
> 
> Cc: stable@...r.kernel.org # for 6.8
> Signed-off-by: Sakari Ailus <sakari.ailus@...ux.intel.com>
Acked-by: Tomas Winkler <tomas.winkler@...el.com>
> ---
>  drivers/misc/mei/vsc-tp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/misc/mei/vsc-tp.c b/drivers/misc/mei/vsc-tp.c index
> ecfb70cd057c..968a92a7425d 100644
> --- a/drivers/misc/mei/vsc-tp.c
> +++ b/drivers/misc/mei/vsc-tp.c
> @@ -419,6 +419,8 @@ static irqreturn_t vsc_tp_isr(int irq, void *data)
> 
>  	atomic_inc(&tp->assert_cnt);
> 
> +	wake_up(&tp->xfer_wait);
> +
>  	return IRQ_WAKE_THREAD;
>  }
> 
> @@ -426,8 +428,6 @@ static irqreturn_t vsc_tp_thread_isr(int irq, void
> *data)  {
>  	struct vsc_tp *tp = data;
> 
> -	wake_up(&tp->xfer_wait);
> -
>  	if (tp->event_notify)
>  		tp->event_notify(tp->event_notify_context);
> 
> --
> 2.34.1