linux-kernel - Re: [PATCH v2 3/3] thermal: gov_power_allocator: Suppress sustainable_power warning without trip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 3 Apr 2024 18:05:36 +0500
From: Nikita Travkin <nikitos.tr@...il.com>
To: Lukasz Luba <lukasz.luba@....com>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>, "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>, 
	linux-pm@...r.kernel.org, Zhang Rui <rui.zhang@...el.com>, 
	Daniel Lezcano <daniel.lezcano@...aro.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/3] thermal: gov_power_allocator: Suppress
 sustainable_power warning without trip_points

ср, 3 апр. 2024 г. в 17:52, Lukasz Luba <lukasz.luba@....com>:
>
>
>
> On 4/3/24 12:31, Nikita Travkin via B4 Relay wrote:
> > From: Nikita Travkin <nikita@...n.ru>
> >
> > IPA warns if the thermal zone it was attached to doesn't define
> > sustainable_power value. In some cases though IPA may be bound to an
> > "empty" TZ, in which case the lack of sustainable_power doesn't matter.
> >
> > Suppress the warning in case when IPA is bound to an empty TZ to make it
> > easier to see the warnings that actually matter.
> >
> > Signed-off-by: Nikita Travkin <nikita@...n.ru>
> > ---
> >
> > I've decided to add this along to supress those warnings for some TZ on
> > sc7180. Feel free to drop this patch if you think the warning should
> > always appear.
>
> That warning should stay, since in the development or integration phase
> quite a lot of stuff is missing. This will warn that there is an issue.
> The case with 'empty' TZ is an exception only to 'work' with IPA.
>

Yes, that's understandable, though by suppressing those I could
actually see the few actual warnings for TZ with cooling devices
and no value, which I couldn't see before because it looked like
"all of them" have the warning.

In any case, as I said, I'm fine with this not being applied :)

Thanks for your review!
Nikita

> Thanks for the patches!
>
> Regards,
> Lukasz
>
>
> > ---
> >   drivers/thermal/gov_power_allocator.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/thermal/gov_power_allocator.c b/drivers/thermal/gov_power_allocator.c
> > index e25e48d76aa7..05a40f6b5928 100644
> > --- a/drivers/thermal/gov_power_allocator.c
> > +++ b/drivers/thermal/gov_power_allocator.c
> > @@ -704,7 +704,7 @@ static int power_allocator_bind(struct thermal_zone_device *tz)
> >               params->allocated_tzp = true;
> >       }
> >
> > -     if (!tz->tzp->sustainable_power)
> > +     if (!tz->tzp->sustainable_power && params->trip_max)
> >               dev_warn(&tz->device, "power_allocator: sustainable_power will be estimated\n");
> >       else
> >               params->sustainable_power = tz->tzp->sustainable_power;
> >