linux-kernel - Re: [PATCH 10/34] efi: sysfb: don't build when EFI is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 03 Apr 2024 15:15:48 +0200
From: Javier Martinez Canillas <javierm@...hat.com>
To: Ard Biesheuvel <ardb@...nel.org>, Arnd Bergmann <arnd@...nel.org>
Cc: linux-kernel@...r.kernel.org, Randy Dunlap <rdunlap@...radead.org>,
 Daniel Vetter <daniel.vetter@...ll.ch>, Arnd Bergmann <arnd@...db.de>,
 Ilias Apalodimas <ilias.apalodimas@...aro.org>, "Kirill A. Shutemov"
 <kirill.shutemov@...ux.intel.com>, Tom Lendacky <thomas.lendacky@....com>,
 "Borislav Petkov (AMD)" <bp@...en8.de>, Masahisa Kojima
 <masahisa.kojima@...aro.org>, "Rafael J. Wysocki" <rafael@...nel.org>, Rob
 Herring <robh@...nel.org>, Saravana Kannan <saravanak@...gle.com>, Greg
 Kroah-Hartman <gregkh@...uxfoundation.org>, linux-efi@...r.kernel.org
Subject: Re: [PATCH 10/34] efi: sysfb: don't build when EFI is disabled

Ard Biesheuvel <ardb@...nel.org> writes:

> On Wed, 3 Apr 2024 at 11:09, Arnd Bergmann <arnd@...nel.org> wrote:
>>
>> From: Arnd Bergmann <arnd@...db.de>
>>
>> With 'make W=1', there is a warning when EFI is turned off but sysfb_efi
>> still gets built:
>>
>> drivers/firmware/efi/sysfb_efi.c:188:35: error: unused variable 'efifb_dmi_system_table' [-Werror,-Wunused-const-variable]
>> static const struct dmi_system_id efifb_dmi_system_table[] __initconst = {
>>                                   ^
>> drivers/firmware/efi/sysfb_efi.c:238:35: error: unused variable 'efifb_dmi_swap_width_height' [-Werror,-Wunused-const-variable]
>> static const struct dmi_system_id efifb_dmi_swap_width_height[] __initconst = {
>>                                   ^
>> drivers/firmware/efi/sysfb_efi.c:297:28: error: unused function 'find_pci_overlap_node' [-Werror,-Wunused-function]
>> static struct device_node *find_pci_overlap_node(void)
>>
>> There was an earlier patch to address the duplicate function definitions, but
>> that missed how we should not be building this file in the first place.
>>
>> Fixes: 15d27b15de96 ("efi: sysfb_efi: fix build when EFI is not set")
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>
> Acked-by: Ard Biesheuvel <ardb@...nel.org>
>

Looks good to me too.

Acked-by: Javier Martinez Canillas <javierm@...hat.com>

> or I can take it via the EFI tree if you prefer.
>

I think that could be merged through your EFI tree. Thanks!

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat