linux-kernel - Re: [PATCH -next] mm/slub: correct comment in do_slab

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 4 Apr 2024 17:55:51 +0200
From: Vlastimil Babka <vbabka@...e.cz>
To: Xiu Jianfeng <xiujianfeng@...weicloud.com>, cl@...ux.com,
 penberg@...nel.org, rientjes@...gle.com, iamjoonsoo.kim@....com,
 akpm@...ux-foundation.org, roman.gushchin@...ux.dev, 42.hyeyoo@...il.com
Cc: linux-mm@...ck.org, linux-kernel@...r.kernel.org, xiujianfeng@...wei.com
Subject: Re: [PATCH -next] mm/slub: correct comment in do_slab_free()

On 3/25/24 1:22 PM, Xiu Jianfeng wrote:
> From: Xiu Jianfeng <xiujianfeng@...wei.com>
> 
> slab_alloc_node() should be __slab_alloc_node().
> 
> Signed-off-by: Xiu Jianfeng <xiujianfeng@...wei.com>

Thanks, added to slab/for-next

> ---
>  mm/slub.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/slub.c b/mm/slub.c
> index 7b68a3451eb9..33ac769a69b9 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -4446,7 +4446,7 @@ static __always_inline void do_slab_free(struct kmem_cache *s,
>  	c = raw_cpu_ptr(s->cpu_slab);
>  	tid = READ_ONCE(c->tid);
>  
> -	/* Same with comment on barrier() in slab_alloc_node() */
> +	/* Same with comment on barrier() in __slab_alloc_node() */
>  	barrier();
>  
>  	if (unlikely(slab != c->slab)) {