[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 04 Apr 2024 13:47:19 -0400
From: Nicolas Dufresne <nicolas@...fresne.ca>
To: Conor Dooley <conor@...nel.org>, Emmanuel Gil Peyrot
<linkmauve@...kmauve.fr>
Cc: linux-kernel@...r.kernel.org, Ezequiel Garcia
<ezequiel@...guardiasur.com.ar>, Philipp Zabel <p.zabel@...gutronix.de>,
Mauro Carvalho Chehab <mchehab@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley
<conor+dt@...nel.org>, Heiko Stuebner <heiko@...ech.de>, Joerg Roedel
<joro@...tes.org>, Will Deacon <will@...nel.org>, Robin Murphy
<robin.murphy@....com>, Sebastian Reichel
<sebastian.reichel@...labora.com>, Cristian Ciocaltea
<cristian.ciocaltea@...labora.com>, Dragan Simic <dsimic@...jaro.org>,
Shreeya Patel <shreeya.patel@...labora.com>, Chris Morgan
<macromorgan@...mail.com>, Andy Yan <andy.yan@...k-chips.com>, Nicolas
Frattaroli <frattaroli.nicolas@...il.com>, linux-media@...r.kernel.org,
linux-rockchip@...ts.infradead.org, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, iommu@...ts.linux.dev
Subject: Re: [PATCH v2 1/2] media: dt-binding: media: Document
rk3588’s VEPU121
Le mercredi 27 mars 2024 à 17:23 +0000, Conor Dooley a écrit :
> On Wed, Mar 27, 2024 at 02:41:11PM +0100, Emmanuel Gil Peyrot wrote:
> > This encoder-only device is present four times on this SoC, and should
> > support everything the rk3568 vepu supports (so JPEG, H.264 and VP8
> > encoding).
> >
> > According to the TRM[1], there is also the VEPU580 encoder which
> > supports H.264 and H.265, and various VDPU* decoders, of which only the
> > VDPU981 is currently supported. This patch describes only the VEPU121.
> >
> > [1] https://github.com/FanX-Tek/rk3588-TRM-and-Datasheet
> >
> > Signed-off-by: Emmanuel Gil Peyrot <linkmauve@...kmauve.fr>
>
> Acked-by: Conor Dooley <conor.dooley@...rochip.com>
I'd like to prevent this change until we fix the driver. It should not expose 1
video device per core, it should instead do schedule around these cores.
Nicolas
>
> Thanks,
> Conor.
>
> > ---
> > .../devicetree/bindings/media/rockchip,rk3568-vepu.yaml | 8 ++++++--
> > 1 file changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/media/rockchip,rk3568-vepu.yaml b/Documentation/devicetree/bindings/media/rockchip,rk3568-vepu.yaml
> > index 9d90d8d0565a..4c6cb21da041 100644
> > --- a/Documentation/devicetree/bindings/media/rockchip,rk3568-vepu.yaml
> > +++ b/Documentation/devicetree/bindings/media/rockchip,rk3568-vepu.yaml
> > @@ -15,8 +15,12 @@ description:
> >
> > properties:
> > compatible:
> > - enum:
> > - - rockchip,rk3568-vepu
> > + oneOf:
> > + - const: rockchip,rk3568-vepu
> > + - items:
> > + - enum:
> > + - rockchip,rk3588-vepu121
> > + - const: rockchip,rk3568-vepu
> >
> > reg:
> > maxItems: 1
> > --
> > 2.44.0
> >
Powered by blists - more mailing lists