linux-kernel - Re: [PATCH] mfd: ocelot-spi: Use spi_sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 4 Apr 2024 14:38:37 -0500
From: Colin Foster <colin.foster@...advantage.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: Lee Jones <lee@...nel.org>, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] mfd: ocelot-spi: Use spi_sync_transfer()

On Thu, Apr 04, 2024 at 09:25:09PM +0200, Christophe JAILLET wrote:
> Use spi_sync_transfer() instead of hand-writing it.
> It is less verbose.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
>  drivers/mfd/ocelot-spi.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/mfd/ocelot-spi.c b/drivers/mfd/ocelot-spi.c
> index 94f82677675b..b015c8683f1b 100644
> --- a/drivers/mfd/ocelot-spi.c
> +++ b/drivers/mfd/ocelot-spi.c
> @@ -145,7 +145,6 @@ static int ocelot_spi_regmap_bus_read(void *context, const void *reg, size_t reg
>  	struct device *dev = context;
>  	struct ocelot_ddata *ddata;
>  	struct spi_device *spi;
> -	struct spi_message msg;
>  	unsigned int index = 0;
>  
>  	ddata = dev_get_drvdata(dev);
> @@ -166,9 +165,7 @@ static int ocelot_spi_regmap_bus_read(void *context, const void *reg, size_t reg
>  	xfers[index].len = val_size;
>  	index++;
>  
> -	spi_message_init_with_transfers(&msg, xfers, index);
> -
> -	return spi_sync(spi, &msg);
> +	return spi_sync_transfer(spi, xfers, index);
>  }
>  

Thanks! I am fighting an unrelated SPI regression, so I tested against 6.7

Reviewed-by: Colin Foster <colin.foster@...advantage.com>
Tested-by: Colin Foster <colin.foster@...advantage.com>