linux-kernel - Re: [PATCH v3 0/3] page_owner: Fix refcount imbalance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 04 Apr 2024 15:56:43 -0700 (PDT)
From: Palmer Dabbelt <palmer@...belt.com>
To: alex@...ti.fr
CC: osalvador@...e.de, akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
  linux-mm@...ck.org, mhocko@...e.com, vbabka@...e.cz, elver@...gle.com, andreyknvl@...il.com,
  glider@...gle.com
Subject:     Re: [PATCH v3 0/3] page_owner: Fix refcount imbalance

On Thu, 28 Mar 2024 23:39:33 PDT (-0700), alex@...ti.fr wrote:
> Hi Oscar,
>
> On 26/03/2024 07:30, Oscar Salvador wrote:
>> This series consists of a refactoring/correctness of updating the metadata
>> of tail pages and a couple of fixups for the refcounting part.
>>
>>  From this series on, instead of counting the stacks, we count the outstanding
>> nr_base_pages each stack has, which gives us a much better memory overview.
>> The other fixup is for the migration part.
>>
>> A more detailed explanation can be found in the changelog of the respective
>> patches.
>>
>> Oscar Salvador (3):
>>    mm,page_owner: Update metada for tail pages
>>    mm,page_owner: Fix refcount imbalance
>>    mm,page_owner: Fix accounting of pages when migrating
>>
>>   Documentation/mm/page_owner.rst |  73 +++++++------
>>   mm/page_owner.c                 | 184 +++++++++++++++++++-------------
>>   2 files changed, 146 insertions(+), 111 deletions(-)
>>
>
> This fixes the following report from syzbot:
> https://lore.kernel.org/linux-riscv/00000000000070a2660614b83885@google.com/T/#t
>
> So you can add:
>
> Tested-by: Alexandre Ghiti <alexghiti@...osinc.com>

Acked-by: Palmer Dabbelt <palmer@...osinc.com>

in case that helps any, but I think this is one for the MM folks  Thanks 
for chasing down the fix!

> Thanks,
>
> Alex