linux-kernel - Re: [PATCH] fixup! selftests/mm: run_vmtests.sh: fix hugetlb mem size calculation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 4 Apr 2024 08:39:40 +0100
From: Ryan Roberts <ryan.roberts@....com>
To: peterx@...hat.com, linux-mm@...ck.org, linux-kernel@...r.kernel.org
Cc: Andrew Morton <akpm@...ux-foundation.org>,
 Muhammad Usama Anjum <usama.anjum@...labora.com>,
 David Hildenbrand <david@...hat.com>, Muchun Song <muchun.song@...ux.dev>
Subject: Re: [PATCH] fixup! selftests/mm: run_vmtests.sh: fix hugetlb mem size
 calculation

On 03/04/2024 21:03, peterx@...hat.com wrote:
> From: Peter Xu <peterx@...hat.com>
> 
> Fix up a breakage on uffd hugetlb test due to removal of a temp variable,
> as reported by Ryan [1].
> 
> Instead of using the previous calculation, use the largest we can
> have (which is put in freepgs) and cut it into half for userfault tests.
> 
> [1] https://lore.kernel.org/r/1c20b717-c5b5-4bdf-8fcd-d46db135b7fa@arm.com
> 
> Cc: Muhammad Usama Anjum <usama.anjum@...labora.com>
> Cc: David Hildenbrand <david@...hat.com>
> Cc: Muchun Song <muchun.song@...ux.dev>
> Reported-by: Ryan Roberts <ryan.roberts@....com>
> Signed-off-by: Peter Xu <peterx@...hat.com>

All passing again for me:

Tested-by: Ryan Roberts <ryan.roberts@....com>

> ---
>  tools/testing/selftests/mm/run_vmtests.sh | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh
> index b1b78e45d613..223c2304f885 100755
> --- a/tools/testing/selftests/mm/run_vmtests.sh
> +++ b/tools/testing/selftests/mm/run_vmtests.sh
> @@ -298,7 +298,8 @@ CATEGORY="userfaultfd" run_test ./uffd-unit-tests
>  uffd_stress_bin=./uffd-stress
>  CATEGORY="userfaultfd" run_test ${uffd_stress_bin} anon 20 16
>  # Hugetlb tests require source and destination huge pages. Pass in half
> -# the size ($half_ufd_size_MB), which is used for *each*.
> +# the size of the free pages we have, which is used for *each*.
> +half_ufd_size_MB=$((freepgs / 2))
>  CATEGORY="userfaultfd" run_test ${uffd_stress_bin} hugetlb "$half_ufd_size_MB" 32
>  CATEGORY="userfaultfd" run_test ${uffd_stress_bin} hugetlb-private "$half_ufd_size_MB" 32
>  CATEGORY="userfaultfd" run_test ${uffd_stress_bin} shmem 20 16