linux-kernel - Re: [PATCH] iio: adc: ad7173: Fix ! vs ~ typo in ad7173_sel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8faeeb203456ceb8c07c5f2a46f8a7b367f574e4.camel@gmail.com>
Date: Thu, 04 Apr 2024 11:03:29 +0200
From: Nuno Sá <noname.nuno@...il.com>
To: Dan Carpenter <dan.carpenter@...aro.org>, Dumitru Ceclan
	 <mitrutzceclan@...il.com>
Cc: Lars-Peter Clausen <lars@...afoo.de>, Michael Hennerich
 <Michael.Hennerich@...log.com>, Jonathan Cameron <jic23@...nel.org>,
 Michael Walle <michael@...le.cc>, Andy Shevchenko <andy@...nel.org>, Nuno
 Sa <nuno.sa@...log.com>,  linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org,  kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] iio: adc: ad7173: Fix ! vs ~ typo in ad7173_sel_clk()

On Thu, 2024-04-04 at 10:31 +0300, Dan Carpenter wrote:
> This was obviously supposed to be a bitwise negate instead of logical.
> 
> Fixes: 76a1e6a42802 ("iio: adc: ad7173: add AD7173 driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---

Reviewed-by: Nuno Sa <nuno.sa@...log.com>

>  drivers/iio/adc/ad7173.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/ad7173.c b/drivers/iio/adc/ad7173.c
> index 4ff6ce46b02c..b1d6ea17ced3 100644
> --- a/drivers/iio/adc/ad7173.c
> +++ b/drivers/iio/adc/ad7173.c
> @@ -835,7 +835,7 @@ static unsigned long ad7173_sel_clk(struct ad7173_state
> *st,
>  {
>  	int ret;
>  
> -	st->adc_mode &= !AD7173_ADC_MODE_CLOCKSEL_MASK;
> +	st->adc_mode &= ~AD7173_ADC_MODE_CLOCKSEL_MASK;
>  	st->adc_mode |= FIELD_PREP(AD7173_ADC_MODE_CLOCKSEL_MASK, clk_sel);
>  	ret = ad_sd_write_reg(&st->sd, AD7173_REG_ADC_MODE, 0x2, st-
> >adc_mode);
>