linux-kernel - [PATCH v1] mtd: spinand: Add support for 5-byte IDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date: Thu, 4 Apr 2024 15:15:21 +0300
From: Dmitry Rokosov <ddrokosov@...utedevices.com>
To: <quic_sridsn@...cinc.com>, <quic_mdalam@...cinc.com>, <ezra@...yb.ch>,
	<gch981213@...il.com>, <miquel.raynal@...tlin.com>, <richard@....at>,
	<sashal@...nel.org>, <gregkh@...uxfoundation.org>, <vigneshr@...com>
CC: <kernel@...utedevices.com>, <rockosov@...il.com>,
	<linux-kernel@...r.kernel.org>, <linux-mtd@...ts.infradead.org>, Ezra Buehler
	<ezra.buehler@...qvarnagroup.com>, <stable@...r.kernel.org>, Martin Kurbanov
	<mmkurbanov@...utedevices.com>, Dmitry Rokosov <ddrokosov@...utedevices.com>
Subject: [PATCH v1] mtd: spinand: Add support for 5-byte IDs

From: Ezra Buehler <ezra.buehler@...qvarnagroup.com>

[ Upstream commit 34a956739d295de6010cdaafeed698ccbba87ea4 ]

E.g. ESMT chips will return an identification code with a length of 5
bytes. In order to prevent ambiguity, flash chips would actually need to
return IDs that are up to 17 or more bytes long due to JEDEC's
continuation scheme. I understand that if a manufacturer ID is located
in bank N of JEDEC's database (there are currently 16 banks), N - 1
continuation codes (7Fh) need to be added to the identification code
(comprising of manufacturer ID and device ID). However, most flash chip
manufacturers don't seem to implement this (correctly).

Cc: <stable@...r.kernel.org> # 6.6.23
Cc: <stable@...r.kernel.org> # 6.7.11
Cc: <stable@...r.kernel.org> # 6.8.2
Signed-off-by: Ezra Buehler <ezra.buehler@...qvarnagroup.com>
Reviewed-by: Martin Kurbanov <mmkurbanov@...utedevices.com>
Tested-by: Martin Kurbanov <mmkurbanov@...utedevices.com>
Signed-off-by: Miquel Raynal <miquel.raynal@...tlin.com>
Link: https://lore.kernel.org/linux-mtd/20240125200108.24374-2-ezra@easyb.ch
Signed-off-by: Dmitry Rokosov <ddrokosov@...utedevices.com>
---

In the patch series [1] only one patch was marked with Fixes tag, that's
why the secon patch was not applied to 6.6.y, 6.7.y and 6.8y. It breaks
ESMT detection flow with logs:

[    0.770730] spi-nand spi0.0: unknown raw ID c8017f7f
[    0.772688] spi-nand: probe of spi0.0 failed with error -524

Please cherry-pick the second patch from the series to 6.6.y, 6.7.y and
6.8.y.

Links:
    [1] https://lore.kernel.org/linux-mtd/20240125200108.24374-1-ezra@easyb.ch/

---
 include/linux/mtd/spinand.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/mtd/spinand.h b/include/linux/mtd/spinand.h
index badb4c1ac079..5c19ead60499 100644
--- a/include/linux/mtd/spinand.h
+++ b/include/linux/mtd/spinand.h
@@ -169,7 +169,7 @@
 struct spinand_op;
 struct spinand_device;
 
-#define SPINAND_MAX_ID_LEN	4
+#define SPINAND_MAX_ID_LEN	5
 /*
  * For erase, write and read operation, we got the following timings :
  * tBERS (erase) 1ms to 4ms
-- 
2.43.0