linux-kernel - [PATCH] platform/x86: quickstart: fix Kconfig selects

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date: Thu,  4 Apr 2024 14:34:30 +0200
From: Arnd Bergmann <arnd@...nel.org>
To: Hans de Goede <hdegoede@...hat.com>,
	Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
	Armin Wolf <W_Armin@....de>
Cc: Arnd Bergmann <arnd@...db.de>,
	Henning Schild <henning.schild@...mens.com>,
	SungHwan Jung <onenowy@...il.com>,
	Ai Chao <aichao@...inos.cn>,
	Robert Joslyn <robert.joslyn@...rectangle.org>,
	Henry Shi <henryshi2018@...il.com>,
	Heiner Kallweit <hkallweit1@...il.com>,
	platform-driver-x86@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH] platform/x86: quickstart: fix Kconfig selects

From: Arnd Bergmann <arnd@...db.de>

The new driver Kconfig entry has a typo that causes a link failure
when CONFIG_INPUT_SPARSEKMAP is disabled:

x86_64-linux-ld: drivers/platform/x86/quickstart.o: in function `quickstart_notify':
quickstart.c:(.text+0x96): undefined reference to `sparse_keymap_report_event'
x86_64-linux-ld: drivers/platform/x86/quickstart.o: in function `quickstart_probe':
quickstart.c:(.text+0x1da): undefined reference to `sparse_keymap_setup'

Select this symbol instead of the incorrect INPUT_SPARSE_KEYMAP.

Fixes: afd66f2a739e ("platform/x86: Add ACPI quickstart button (PNP0C32) driver")
Signed-off-by: Arnd Bergmann <arnd@...db.de>
---
 drivers/platform/x86/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index ba88a7f259f1..21a37f1b73ab 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -647,7 +647,7 @@ config ACPI_QUICKSTART
 	tristate "ACPI Quickstart button driver"
 	depends on ACPI
 	depends on INPUT
-	select INPUT_SPARSE_KEYMAP
+	select INPUT_SPARSEKMAP
 	help
 	  This driver adds support for ACPI quickstart button (PNP0C32) devices.
 	  The button emits a manufacturer-specific key value when pressed, so
-- 
2.39.2