linux-kernel - Re: [PATCH 4/4] x86/xen: Enumerate NX from CPUID directly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 4 Apr 2024 07:24:11 -0700
From: Dave Hansen <dave.hansen@...el.com>
To: Jürgen Groß <jgross@...e.com>,
 Dave Hansen <dave.hansen@...ux.intel.com>, linux-kernel@...r.kernel.org
Cc: tglx@...utronix.de, x86@...nel.org, bp@...en8.de
Subject: Re: [PATCH 4/4] x86/xen: Enumerate NX from CPUID directly

On 4/4/24 03:44, Jürgen Groß wrote:
>> @@ -1306,6 +1306,21 @@ static void __init xen_domu_set_legacy_f
>>     extern void early_xen_iret_patch(void);
>>   +/*
>> + * It is too early for boot_cpu_has() and friends to work.
>> + * Use CPUID to directly enumerate NX support.
>> + */
>> +static inline void xen_configure_nx(void)
>> +{
>> +    bool nx_supported;
>> +    u32 eax = 0;
> 
> I'd prefer to name this variable edx.
> 
>> +
>> +    get_cpuid_region_leaf(0x80000001, CPUID_EDX, &eax); 

Heh.  That's a nice way to say it. :)

I'll fix it up.