linux-kernel - Re: [linus:master] [serial] 43066e3222: BUG:kernel_NULL_pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 4 Apr 2024 17:42:29 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Tony Lindgren <tony@...mide.com>
Cc: kernel test robot <oliver.sang@...el.com>,
	Yicong Yang <yangyicong@...ilicon.com>, oe-lkp@...ts.linux.dev,
	lkp@...el.com, linux-kernel@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	stable <stable@...nel.org>, linux-serial@...r.kernel.org
Subject: Re: [linus:master] [serial]  43066e3222:
 BUG:kernel_NULL_pointer_dereference,address

On Thu, Apr 04, 2024 at 02:59:19PM +0300, Andy Shevchenko wrote:
> On Thu, Apr 04, 2024 at 09:54:15AM +0300, Tony Lindgren wrote:
> > * Andy Shevchenko <andriy.shevchenko@...ux.intel.com> [240403 14:00]:
> > > Probably we need to check if the port is still open...
> > > 
> > > P.S. AFAIU the state / xmit is invalid pointer or so.
> > > 
> > > Culprit line:	serial_out(up, UART_TX, xmit->buf[xmit->tail]);
> 
> xmit.buf seems to be NULL, that's why this fails.
> 
> > Maybe we can set UPF_DEAD a bit earlier as below?
> 
> Lemme perform some tests later today.

Okay, so far it doesn't fix the issue AFAICT. The only reliable one right now
to me is clearing circ buffer before NULLifying it.

I'll send a formal patch.

-- 
With Best Regards,
Andy Shevchenko