linux-kernel - Re: [PATCH v1 1/1] gpio: wcove: Use -ENOTSUPP consistently

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <564688b7-7d21-414d-9878-5a736777660d@linux.intel.com>
Date: Fri, 5 Apr 2024 09:46:40 -0700
From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@...ux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: Andy Shevchenko <andy@...nel.org>,
 Linus Walleij <linus.walleij@...aro.org>, Bartosz Golaszewski
 <brgl@...ev.pl>, Cristian Marussi <cristian.marussi@....com>,
 Sudeep Holla <sudeep.holla@....com>, peng.fan@....nxp.com
Subject: Re: [PATCH v1 1/1] gpio: wcove: Use -ENOTSUPP consistently


On 4/5/24 9:25 AM, Andy Shevchenko wrote:
> The GPIO library expects the drivers to return -ENOTSUPP in some
> cases and not using analogue POSIX code. Make the driver to follow
> this.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---

Looks good to me.

Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@...ux.intel.com>

>  drivers/gpio/gpio-wcove.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-wcove.c b/drivers/gpio/gpio-wcove.c
> index c18b6b47384f..94ca9d03c094 100644
> --- a/drivers/gpio/gpio-wcove.c
> +++ b/drivers/gpio/gpio-wcove.c
> @@ -104,7 +104,7 @@ static inline int to_reg(int gpio, enum ctrl_register type)
>  	unsigned int reg = type == CTRL_IN ? GPIO_IN_CTRL_BASE : GPIO_OUT_CTRL_BASE;
>  
>  	if (gpio >= WCOVE_GPIO_NUM)
> -		return -EOPNOTSUPP;
> +		return -ENOTSUPP;
>  
>  	return reg + gpio;
>  }

-- 
Sathyanarayanan Kuppuswamy
Linux Kernel Developer