linux-kernel - Re: [PATCH] phy: xilinx: Convert to platform remove callback returning void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <171233694977.304553.16769485052582751352.b4-ty@kernel.org>
Date: Fri, 05 Apr 2024 22:39:09 +0530
From: Vinod Koul <vkoul@...nel.org>
To: Laurent Pinchart <laurent.pinchart@...asonboard.com>, 
 Kishon Vijay Abraham I <kishon@...nel.org>, 
 Michal Simek <michal.simek@....com>, 
 Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Cc: linux-kernel@...r.kernel.org, linux-phy@...ts.infradead.org, 
 linux-arm-kernel@...ts.infradead.org, kernel@...gutronix.de
Subject: Re: [PATCH] phy: xilinx: Convert to platform remove callback
 returning void


On Fri, 08 Mar 2024 09:51:13 +0100, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
> 
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
> 
> [...]

Applied, thanks!

[1/1] phy: xilinx: Convert to platform remove callback returning void
      commit: 7dcb8668aedc5603cba1f2625c6051beff03797d

Best regards,
-- 
~Vinod