linux-kernel - Re: [PATCH v3 2/3] arm64: tlb: Improve __TLBI_VADDR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZhAwnohowDjIUzby@arm.com>
Date: Fri, 5 Apr 2024 18:10:54 +0100
From: Catalin Marinas <catalin.marinas@....com>
To: Gavin Shan <gshan@...hat.com>
Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	will@...nel.org, akpm@...ux-foundation.org, maz@...nel.org,
	oliver.upton@...ux.dev, ryan.roberts@....com, apopple@...dia.com,
	rananta@...gle.com, mark.rutland@....com, v-songbaohua@...o.com,
	yangyicong@...ilicon.com, shahuang@...hat.com, yihyu@...hat.com,
	shan.gavin@...il.com
Subject: Re: [PATCH v3 2/3] arm64: tlb: Improve __TLBI_VADDR_RANGE()

On Fri, Apr 05, 2024 at 01:58:51PM +1000, Gavin Shan wrote:
> The macro returns the operand of TLBI RANGE instruction. A mask needs
> to be applied to each individual field upon producing the operand, to
> avoid the adjacent fields can interfere with each other when invalid
> arguments have been provided. The code looks more tidy at least with
> a mask and FIELD_PREP().
> 
> Suggested-by: Marc Zyngier <maz@...nel.org>
> Signed-off-by: Gavin Shan <gshan@...hat.com>

Reviewed-by: Catalin Marinas <catalin.marinas@....com>