[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <1712340972-13643-1-git-send-email-venkat.x.venkatsubra@oracle.com>
Date: Fri, 5 Apr 2024 11:16:12 -0700
From: Venkat Venkatsubra <venkat.x.venkatsubra@...cle.com>
To: davem@...emloft.net, netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
maheshb@...gle.com, edumazet@...gle.com, kuba@...nel.org
Cc: gia-khanh.nguyen@...cle.com
Subject: [PATCH net-next v2] ipvlan: handle NETDEV_DOWN event
In case of stacked devices, to help propagate the down
link state from the parent/root device (to this leaf device),
handle NETDEV_DOWN event like it is done now for NETDEV_UP.
In the below example, ens5 is the host interface which is the
parent of the ipvlan interface eth0 in the container.
Host:
[root@...-podman-x64 ~]# ip link set ens5 down
[root@...-podman-x64 ~]# ip -d link show dev ens5
3: ens5: <BROADCAST,MULTICAST> mtu 9000 qdisc mq state DOWN
...
[root@...-podman-x64 ~]#
Container:
[root@...tnode-ol8 /]# ip -d link show dev eth0
2: eth0@if3: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 9000 state UNKNOWN
...
ipvlan mode l2 bridge
...
[root@...tnode-ol8 /]#
eth0's state continues to show up as UP even though ens5 is now DOWN.
For macvlan the handling of NETDEV_DOWN event was added in
commit 80fd2d6ca546 ("macvlan: Change status when lower device goes down").
Reported-by: Gia-Khanh Nguyen <gia-khanh.nguyen@...cle.com>
Signed-off-by: Venkat Venkatsubra <venkat.x.venkatsubra@...cle.com>
---
drivers/net/ipvlan/ipvlan_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ipvlan/ipvlan_main.c b/drivers/net/ipvlan/ipvlan_main.c
index 5920f7e63352..094f44dac5c8 100644
--- a/drivers/net/ipvlan/ipvlan_main.c
+++ b/drivers/net/ipvlan/ipvlan_main.c
@@ -735,6 +735,7 @@ static int ipvlan_device_event(struct notifier_block *unused,
switch (event) {
case NETDEV_UP:
+ case NETDEV_DOWN:
case NETDEV_CHANGE:
list_for_each_entry(ipvlan, &port->ipvlans, pnode)
netif_stacked_transfer_operstate(ipvlan->phy_dev,
--
1.8.3.1
Powered by blists - more mailing lists